mb_str_split() / str_split() always returns `non-empty-array` #633

staabm · 2021-08-20T11:17:04Z

staabm · 2021-08-20T11:31:18Z

tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php

 				'$strSplitConstantStringWithInvalidSplitLengthType',
 			],
 			[
 				'array<int, string>&nonEmpty',
 				'$strSplitConstantStringWithVariableStringAndConstantSplitLength',
 			],
 			[
-				PHP_VERSION_ID < 80000 ? 'array<int, string>|false' : 'array<int, string>',
+				PHP_VERSION_ID < 80000 ? '(array<int, string>&nonEmpty)|false' : 'array<int, string>&nonEmpty',


interessting.. sometimes a type including braces is produced, and sometimes without

phpstan-src/src/Type/UnionType.php

Lines 150 to 168 in 119facc

$joinTypes = static function (array $types) use ($level): string {

$typeNames = [];

foreach ($types as $type) {

if ($type instanceof ClosureType || $type instanceof CallableType) {

$typeNames[] = sprintf('(%s)', $type->describe($level));

} elseif ($type instanceof IntersectionType) {

$intersectionDescription = $type->describe($level);

if (strpos($intersectionDescription, '&') !== false) {

$typeNames[] = sprintf('(%s)', $type->describe($level));

} else {

$typeNames[] = $intersectionDescription;

}

} else {

$typeNames[] = $type->describe($level);

}

}

return implode('|', $typeNames);

};

src/Type/Php/StrSplitFunctionReturnTypeExtension.php

Call to function is_array() with array<int, string>&nonEmpty will always evaluate to true.

src/Type/Php/StrSplitFunctionReturnTypeExtension.php

staabm · 2021-08-23T14:46:52Z

@ondrejmirtes fixed remaining php8 error. should be good to go

ondrejmirtes · 2021-08-23T20:34:21Z

Thank you!

staabm mentioned this pull request Aug 20, 2021

str_split() length parameter is always positive #631

Merged

staabm changed the title ~~(mb_)?str_split() always returns non-empty-array~~ (mb_)?str_split() always returns non-empty-array Aug 20, 2021

staabm commented Aug 20, 2021

View reviewed changes

staabm force-pushed the str-split branch from 4c0266f to 703459d Compare August 20, 2021 11:34

staabm commented Aug 20, 2021

View reviewed changes

src/Type/Php/StrSplitFunctionReturnTypeExtension.php Show resolved Hide resolved

staabm added 3 commits August 20, 2021 13:42

(mb_)?str_split() always returns non-empty-array

6bbca56

fix tests

7fefa4e

remove dead code

dbfc9f7

Call to function is_array() with array<int, string>&nonEmpty will always evaluate to true.

staabm force-pushed the str-split branch from 703459d to dbfc9f7 Compare August 20, 2021 11:42

staabm added 2 commits August 20, 2021 13:46

adjust test expectations

bc3c64f

adjusted should-not-happen condition

4a526b1

staabm commented Aug 20, 2021

View reviewed changes

src/Type/Php/StrSplitFunctionReturnTypeExtension.php Show resolved Hide resolved

fix php8 baseline

7036765

staabm changed the title ~~(mb_)?str_split() always returns non-empty-array~~ mb_str_split() / str_split() always returns non-empty-array Aug 23, 2021

ondrejmirtes merged commit 8bf2fe0 into phpstan:master Aug 23, 2021

staabm deleted the str-split branch August 27, 2021 11:56

herndlm mentioned this pull request Jul 6, 2022

Fix handling of str_split / mb_str_split string arg compound types + default return type for mb_str_split #1496

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mb_str_split() / str_split() always returns `non-empty-array` #633

mb_str_split() / str_split() always returns `non-empty-array` #633

staabm commented Aug 20, 2021 •

edited

staabm Aug 20, 2021 •

edited

ondrejmirtes Aug 20, 2021

staabm commented Aug 23, 2021

ondrejmirtes commented Aug 23, 2021

	$joinTypes = static function (array $types) use ($level): string {
	$typeNames = [];
	foreach ($types as $type) {
	if ($type instanceof ClosureType \|\| $type instanceof CallableType) {
	$typeNames[] = sprintf('(%s)', $type->describe($level));
	} elseif ($type instanceof IntersectionType) {
	$intersectionDescription = $type->describe($level);
	if (strpos($intersectionDescription, '&') !== false) {
	$typeNames[] = sprintf('(%s)', $type->describe($level));
	} else {
	$typeNames[] = $intersectionDescription;
	}
	} else {
	$typeNames[] = $type->describe($level);
	}
	}

	return implode('\|', $typeNames);
	};

mb_str_split() / str_split() always returns non-empty-array #633

mb_str_split() / str_split() always returns non-empty-array #633

Conversation

staabm commented Aug 20, 2021 • edited

staabm Aug 20, 2021 • edited

Choose a reason for hiding this comment

ondrejmirtes Aug 20, 2021

Choose a reason for hiding this comment

staabm commented Aug 23, 2021

ondrejmirtes commented Aug 23, 2021

mb_str_split() / str_split() always returns `non-empty-array` #633

mb_str_split() / str_split() always returns `non-empty-array` #633

staabm commented Aug 20, 2021 •

edited

staabm Aug 20, 2021 •

edited