-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 4949, support closure bind with class-string #706
Fix 4949, support closure bind with class-string #706
Conversation
75cdfda
to
e0f5a41
Compare
88c36dd
to
97b71e4
Compare
@ondrejmirtes can you please review this PR? Also, the releases stopped at 0.12.99 about 2 months ago, is it planned and does it mean some big changes are comming? |
I belive this PR is done, can you please review and merge? Thanks. |
@ondrejmirtes can you please review this PR? |
@mvorisek You're in the same pool as everyone else so you have to wait |
src/Analyser/NodeScopeResolver.php
Outdated
} elseif ($argValueType instanceof ConstantStringType) { | ||
$scopeClass = $argValueType->getValue(); | ||
$thisType = new ObjectType($scopeClass); | ||
} elseif ( | ||
$argValueType instanceof GenericClassStringType | ||
&& $argValueType->getGenericType() instanceof ObjectType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instanceof TypeWithClassName would be better. Otherwise 👍 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, 👍
97b71e4
to
5ef1b3f
Compare
Thank you. |
fixes phpstan/phpstan#4949