Added DynamicReturnTypeExtension for trigger_error
#766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build errors are unrelated |
|
rebased against master. all green now. |
ondrejmirtes
requested changes
Nov 19, 2021
| $errorType = $scope->getType($functionCall->getArgs()[1]->value); | ||
| if ($errorType instanceof ConstantScalarType) { | ||
| if ($errorType->getValue() === E_USER_ERROR) { | ||
| return new NeverType(); |
There was a problem hiding this comment.
We should also test that this behaves as an actual terminating call. Try this:
function foo(?string $s): void
{
if ($s === null) {
trigger_error('foo', E_USER_ERROR);
}
assertType('string', $s);
}There was a problem hiding this comment.
hmm interessting.. you are right, this case is failling atm.
I had the impression that phpstan would handle a NeverType returned from a DynamicFunctionReturnTypeExtension automatically as a terminating call. wouldn't that make sense, instead of adding such logic case by case?
There was a problem hiding this comment.
You need return new NeverType(true);
There was a problem hiding this comment.
already fixed :-). thx.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#5992