feat(analyze): add an option to allow generating empty baseline #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whats the motivation of this PR? In case you are interessted in a 0 exit code, you can use |
|
This will not generate an empty baseline file. And by empty, I mean with this content : |
|
See #751 (comment) |
ondrejmirtes
requested changes
Nov 19, 2021
| @@ -55,6 +55,7 @@ protected function configure(): void | |||
| new InputOption('autoload-file', 'a', InputOption::VALUE_REQUIRED, 'Project\'s additional autoload file path'), | |||
| new InputOption('error-format', null, InputOption::VALUE_REQUIRED, 'Format in which to print the result of the analysis', null), | |||
| new InputOption('generate-baseline', null, InputOption::VALUE_OPTIONAL, 'Path to a file where the baseline should be saved', false), | |||
| new InputOption('allow-empty-baseline', null, InputOption::VALUE_NONE, 'Do not error out when the generated baseline is empty'), | |||
There was a problem hiding this comment.
You can't set a default on an input option which has no value.
There was a problem hiding this comment.
Oh right, haven't realized that 👍
| @@ -102,6 +103,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $generateBaselineFile = 'phpstan-baseline.neon'; | |||
| } | |||
|
|
|||
| $allowEmptyBaseline = (bool) $input->getOption('allow-empty-baseline'); | |||
There was a problem hiding this comment.
This set to true should result in an error if $generateBaselineFile is null.
There was a problem hiding this comment.
Done. I'm not very satisfied with the error message, if you have a better idea...
|
Thank you! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.