imap_delete / imap_undelete: correction #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imap_delete and imap_undelete both have parameter $message_num of type string. All other imap_* - functions have $message_num as int and $message_nums as string. For imap_delete and imap_undelete, it really should be string $message_nums. I also opened a bug at php for this. php doc has correct type, but comment is wrong and parameter names should be changed to be consistent for all imap_*-functions. https://bugs.php.net/bug.php?id=81649
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imap_delete and imap_undelete both have parameter $message_num of type string. All other imap_* - functions have $message_num as int and $message_nums as string.
For imap_delete and imap_undelete, it really should be string $message_nums. I also opened a bug at php for this. php doc has correct type, but comment is wrong and parameter names should be changed to be consistent for all imap_*-functions.
https://bugs.php.net/bug.php?id=81649