Array unpacking support for string-keyed arrays #803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan didn't seem to have support for unpacking string keyed arrays: https://phpstan.org/r/e187af75-320b-4fa6-ba5a-54ceec396f42
This PR adds it only for PHP 8.1 and above.
I think my implementation may not be the best (especially the
$hasStringKey
hackery), feel free to override it or I'd be happy to change it according to suggestions 馃憤馃徑