Fix the signature of the value returned from the date_parse
and date_parse_from_format
functions
#807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, I noticed that the return value of the
date_parse
anddate_parse_from_format
functions is both wrong and incomplete. Accordig tophp-src
, it looks like both functions cannot returnfalse
even in case of parsing failure. Moreover, PHPStan was complaining about my code because it didn't know the shape of the returnedarray