Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrower return types for restore_error_handler() and restore_exception_handler() #850

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

johnbillion
Copy link
Contributor

Both of these functions always return true. Narrowing their documented return types prevents confusion around whether the return value can be used to determine success or failure, which it cannot.

@ondrejmirtes ondrejmirtes merged commit 79a62b0 into phpstan:master Dec 13, 2021
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants