Silent @ operator should use & $errno check

[samsonasik]

refs verified in rector-src and my ErrorHeroModule module with test code for @

• [DX] Avoid reporting deprecated errors rectorphp/rector-src#1577 (review)
• https://github.com/samsonasik/ErrorHeroModule/blob/18b691e880d6e068dd94d17bffcfdd54518d2a4a/src/HeroTrait.php#L112

[samsonasik]

Also referenced to PHP documentation https://www.php.net/manual/en/language.operators.errorcontrol.php#language.operators.errorcontrol

[samsonasik]

All green 🎉

[ondrejmirtes]

Can you please explain the behaviour of this code before/after with some examples? Thanks.

[samsonasik]

As I commented at rectorphp/rector-src#1577 (review), I tried the code in rector-src, with only check error_reporting() === 0, it will end up getting error:

 [ERROR] Could not process "/Users/samsonasik/www/rector-src/src/Application/FileProcessor.php" file, due to:           
         "mkdir(): File exists". On line: 26     

for the following code:

@mkdir('test');
@mkdir('test');

[ondrejmirtes]

Thank you!