Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for assertions resulting in non-empty string #129

Closed
villfa opened this issue Mar 10, 2022 · 2 comments · Fixed by #143
Closed

Support for assertions resulting in non-empty string #129

villfa opened this issue Mar 10, 2022 · 2 comments · Fixed by #143

Comments

@villfa
Copy link
Contributor

villfa commented Mar 10, 2022

See discussion in #128
@herndlm
Copy link
Contributor

herndlm commented May 9, 2022 •
edited

This should be possible to do now thx to phpstan/phpstan-src#1254 which also solved a couple of other problems. See phpstan/phpstan-src#1068 where something similar was done in phpstan itself. I think we should use the same approach here too.
I can take a look at it soon. Or you go ahead if you like :) Just make sure the all* assertions are working fine too, I had to fix something there recently.

@herndlm herndlm mentioned this issue Jul 14, 2022
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support string assertions resulting in non-empty-string herndlm/phpstan-webmozart-assert
2 participants
@villfa @herndlm