Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support string assertions resulting in non-empty-string #143

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Support string assertions resulting in non-empty-string #143

merged 2 commits into from
Sep 21, 2022
+304 −22

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Jul 14, 2022 •
edited

Closes #129

Brings back what was reverted in #89 and steals ideas from #128

@herndlm herndlm marked this pull request as ready for review July 14, 2022 19:44
@herndlm herndlm marked this pull request as draft July 14, 2022 19:46
@herndlm herndlm force-pushed the feature-129 branch 2 times, most recently from 092e729 to 1c6a7b8 Compare July 14, 2022 19:53
@herndlm herndlm marked this pull request as ready for review July 14, 2022 19:54
@herndlm herndlm marked this pull request as draft July 15, 2022 04:12
@herndlm
Copy link
Contributor Author

herndlm commented Jul 15, 2022

I want to check if I can make it report if those functions are called more than once with the same args

@herndlm
Copy link
Contributor Author

herndlm commented Jul 15, 2022

Now it works as I imagined :) I'm gonna add the same double-check-report adaption to phpstan-src with str_contains if possible.

@herndlm herndlm marked this pull request as ready for review July 15, 2022 14:52
@herndlm herndlm marked this pull request as draft July 15, 2022 14:55
@herndlm herndlm marked this pull request as ready for review July 15, 2022 15:41
@herndlm herndlm marked this pull request as draft July 16, 2022 20:59
@herndlm herndlm marked this pull request as ready for review July 17, 2022 18:49
@herndlm
Copy link
Contributor Author

herndlm commented Aug 13, 2022

jfyi in case it was missed - I think this one should be good

@ondrejmirtes
Copy link
Member

Really nice!

@ondrejmirtes ondrejmirtes merged commit c8cd404 into phpstan:1.2.x Sep 21, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@herndlm herndlm deleted the feature-129 branch September 21, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for assertions resulting in non-empty string
2 participants
@herndlm @ondrejmirtes