Fixed PDO::query() parameters

phpstan · Jan 8, 2017 · 06fc09d · 06fc09d
1 parent 098221f
commit 06fc09d
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 0 deletions.
diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -8,6 +8,7 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\ParametersAcceptor;
+use PHPStan\Type\ArrayType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\StringType;
@@ -123,6 +124,33 @@ public function getParameters(): array
 					true
 				);
 			}
+
+			if (
+				$this->declaringClass->getName() === 'PDO'
+				&& $this->reflection->getName() === 'query'
+				&& count($this->parameters) < 4
+			) {
+				$this->parameters[] = new DummyParameter(
+					'statement',
+					new StringType(false),
+					false
+				);
+				$this->parameters[] = new DummyParameter(
+					'fetchColumn',
+					new IntegerType(false),
+					true
+				);
+				$this->parameters[] = new DummyParameter(
+					'colno',
+					new MixedType(),
+					true
+				);
+				$this->parameters[] = new DummyParameter(
+					'constructorArgs',
+					new ArrayType(new MixedType(), false),
+					true
+				);
+			}
 		}
 
 		return $this->parameters;

diff --git a/tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php b/tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php
@@ -110,6 +110,10 @@ public function testCallMethods()
 				'Call to an undefined method ArrayObject::doFoo().',
 				104,
 			],
+			[
+				'Method PDO::query() invoked with 0 parameters, 1-4 required.',
+				109,
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/Methods/data/call-methods.php b/tests/PHPStan/Rules/Methods/data/call-methods.php
@@ -103,3 +103,9 @@ private function returnsVoid()
 	$arrayOfStdClass = new \ArrayObject([new \stdClass()]);
 	$arrayOfStdClass->doFoo();
 };
+
+$g = function () {
+	$pdo = new \PDO('dsn', 'username', 'password');
+	$pdo->query();
+	$pdo->query('statement');
+};