Variable can be assigned inside an array dim fetch inside an isset

phpstan · Dec 12, 2016 · 075b492 · 075b492
1 parent 6f9ff1e
commit 075b492
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -618,6 +618,12 @@ private function lookForAssigns(Scope $scope, \PhpParser\Node $node): Scope
 			$scope = $this->lookForAssigns($scope, $node->expr);
 		} elseif ($node instanceof Foreach_) {
 			$scope = $this->lookForAssigns($scope, $node->expr);
+		} elseif ($node instanceof Isset_) {
+			foreach ($node->vars as $var) {
+				$scope = $this->lookForAssigns($scope, $var);
+			}
+		} elseif ($node instanceof ArrayDimFetch && $node->dim !== null) {
+			$scope = $this->lookForAssigns($scope, $node->dim);
 		}
 
 		$scope = $this->updateScopeForVariableAssign($scope, $node);

diff --git a/tests/PHPStan/Rules/Variables/data/defined-variables.php b/tests/PHPStan/Rules/Variables/data/defined-variables.php
@@ -125,3 +125,10 @@ function () use (&$errorHandler) {
 
 }
 echo $variableAssignedInForeach;
+
+$someArray[$variableDefinedInDimFetch = 1];
+
+if (isset($_[$variableAssignedInIsset = 123]) && $variableAssignedInIsset > 0) {
+	doFoo($variableAssignedInIsset); // defined here
+}
+doFoo($variableAssignedInIsset);