DOMDocument - added missing properties

phpstan · Jan 15, 2017 · 45a41ad · 45a41ad
1 parent e5b2f6a
commit 45a41ad
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/Reflection/PhpDefect/PhpDefectClassReflectionExtension.php b/src/Reflection/PhpDefect/PhpDefectClassReflectionExtension.php
@@ -22,10 +22,14 @@ class PhpDefectClassReflectionExtension implements PropertiesClassReflectionExte
 			'days' => 'mixed',
 		],
 		'DOMDocument' => [
+			'actualEncoding' => 'string',
+			'config' => 'DOMConfiguration',
+			'doctype' => 'DOMDocumentType',
+			'documentElement' => 'DOMElement',
 			'documentURI' => 'string',
 			'encoding' => 'string',
 			'formatOutput' => 'bool',
-			'implementation' => 'bool',
+			'implementation' => 'DOMImplementation',
 			'preserveWhiteSpace' => 'bool',
 			'recover' => 'bool',
 			'resolveExternals' => 'bool',

diff --git a/tests/PHPStan/Reflection/PhpDefect/PhpDefectClassReflectionExtensionTest.php b/tests/PHPStan/Reflection/PhpDefect/PhpDefectClassReflectionExtensionTest.php
@@ -22,7 +22,7 @@ public function testProperties(string $className, string $declaringClassName, ar
 		foreach ($data as $propertyName => $typeDescription) {
 			$broker = $this->getContainer()->getByType(Broker::class);
 			$classReflection = $broker->getClass($className);
-			$this->assertTrue($classReflection->hasProperty($propertyName));
+			$this->assertTrue($classReflection->hasProperty($propertyName), sprintf('%s::$%s', $className, $propertyName));
 			$propertyReflection = $classReflection->getProperty($propertyName);
 			$this->assertInstanceOf(PhpDefectPropertyReflection::class, $propertyReflection);
 			$this->assertSame($declaringClassName, $propertyReflection->getDeclaringClass()->getName());
@@ -71,10 +71,14 @@ public function dataDomDocumentProperties(): array
 				\DOMDocument::class,
 				\DOMDocument::class,
 				[
+					'actualEncoding' => 'string',
+					'config' => 'DOMConfiguration',
+					'doctype' => 'DOMDocumentType',
+					'documentElement' => 'DOMElement',
 					'documentURI' => 'string',
 					'encoding' => 'string',
 					'formatOutput' => 'bool',
-					'implementation' => 'bool',
+					'implementation' => 'DOMImplementation',
 					'preserveWhiteSpace' => 'bool',
 					'recover' => 'bool',
 					'resolveExternals' => 'bool',
@@ -84,6 +88,7 @@ public function dataDomDocumentProperties(): array
 					'validateOnParse' => 'bool',
 					'version' => 'string',
 					'xmlEncoding' => 'string',
+					'xmlStandalone' => 'bool',
 					'xmlVersion' => 'string',
 				],
 			],