Casting a division to float is not always useless

phpstan · Dec 3, 2016 · 5bbf809 · 5bbf809
1 parent 2853c91
commit 5bbf809
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/Rules/Cast/UselessCastRule.php b/src/Rules/Cast/UselessCastRule.php
@@ -6,6 +6,7 @@
 use PhpParser\Node\Expr\Cast;
 use PhpParser\Node\Expr\Cast\Object_;
 use PHPStan\Analyser\Scope;
+use PHPStan\Type\FloatType;
 
 class UselessCastRule implements \PHPStan\Rules\Rule
 {
@@ -32,6 +33,9 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$castType = $scope->getType($node);
+		if ($castType instanceof FloatType && $node->expr instanceof Node\Expr\BinaryOp\Div) {
+			return [];
+		}
 
 		if (get_class($expressionType) === get_class($castType)) {
 			return [

diff --git a/tests/PHPStan/Rules/Cast/data/useless-cast.php b/tests/PHPStan/Rules/Cast/data/useless-cast.php
@@ -11,3 +11,5 @@
 /** @var $nullableString string|null */
 $nullableString = 'foo';
 $foo = (string) $nullableString;
+
+$foo = (float) (6 / 2);