feat: check for and list valid versions and targets programmatically in phylum-init
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in `phylum-init`
* Check for valid versions by using the GitHub API to compare against actual releases
* Supported target triples programmatically generated based on the results
* Users will be told when the version provided as an option is not valid
* Removed `SUPPORTED_TARGET_TRIPLES` static collection
* Add `--list-releases` and `--list-targets` options
* These are mutually exclusive options
* Listing Rust target triples are for a specific release version
* Format and refactor throughout
* Stop using `.get` method on `importlib_metadata.metadata()` results
* See python/importlib_metadata#384
* Add constant for `MIN_SUPPORTED_CLI_VERSION`
cd-work
approved these changes
Jul 13, 2022
cd-work
previously approved these changes
Jul 13, 2022
kylewillmon
previously approved these changes
Jul 13, 2022
kylewillmon
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes on two issues and is relevant now that phylum-dev/cli#528 has been merged into the CLI, adding a new supported platform. The next release of the CLI, with this new supported platform, will cause the
phylum-initscript to be out of date. Instead of updating the static collection of supported platforms, this PR will help to ensure the synchronization is maintained for any changes going forward. Changes include:SUPPORTED_TARGET_TRIPLESstatic collection--list-releasesand--list-targetsoptions.getmethod onimportlib_metadata.metadata()results.jsonmethod is not available for Python 3.8 and 3.9MIN_SUPPORTED_CLI_VERSIONCloses #24
Closes #26
Checklist
closes #<issueNum>in description above)?Have you created sufficient tests?Testing Screenshots