Update Dockerfile to use COPY instead of ADD as recommended on https:… #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy Signed-off-by: TheDen <deniskhoshaba@gmail.com>
TheDen
force-pushed
the
dockerfile-use-copy-instead-of-add
branch
from
6ce5d1f
to
c94ae9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…//docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy
Description
Small improvement based on best practices, unless there's a good reason to use
ADD?Fixes Dockerfile to potentially pass hadolint tests
How Has This Been Tested?
Risk should be low on this
Types of changes
Checklist: