Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number of invalid domains #4445

Merged
merged 2 commits into from Dec 3, 2021
Merged

Fix number of invalid domains #4445

merged 2 commits into from Dec 3, 2021

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 1, 2021

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
During gravity update the number of invalid domains was counted correctly but not saved to the database. Instead it was always 0.

Fixes #4441

How does this PR accomplish the above?:
Remove num_invalid to be set as local in parseList as it is later used in database_adlist_number again to save to the database

Bildschirmfoto zu 2021-12-01 11-11-07

Addition
Some variables in parseList() have been renamed to increase comprehensibility

Co-authored-by: abesnier <besnier_antoine@yahoo.fr>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser linked an issue Dec 1, 2021 that may be closed by this pull request
@yubiuser yubiuser marked this pull request as ready for review December 2, 2021 22:09
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Dec 2, 2021
@yubiuser yubiuser requested a review from a team December 2, 2021 22:10
Signed-off-by: Christian König <ckoenig@posteo.de>
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected

@DL6ER DL6ER merged commit 4c267f7 into development Dec 3, 2021
@DL6ER DL6ER deleted the fix/counting branch December 3, 2021 07:56
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ad list details does not report the invalid domains number
3 participants