Tweaks to functions in utils.sh and refactored usages in webpage.sh #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(adjust test to suit) Add a removeKey function with test update webpage.sh to reference functions in utils.sh (this can likely be abstracted/refactored further) Signed-off-by: Adam Warner <me@adamwarner.co.uk>
dschaper
previously requested changes
Mar 16, 2022
PromoFaux
force-pushed
the
refactor-utils-redux
branch
from
b4efb36
to
bedf472
Compare
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
PromoFaux
force-pushed
the
refactor-utils-redux
branch
from
bedf472
to
59fc380
Compare
PromoFaux
force-pushed
the
refactor-utils-redux
branch
from
678ce56
to
ee0f0bd
Compare
PromoFaux
force-pushed
the
refactor-utils-redux
branch
from
ee0f0bd
to
b8f703f
Compare
PromoFaux
force-pushed
the
refactor-utils-redux
branch
from
b8f703f
to
7fa8cdd
Compare
yubiuser
reviewed
Apr 4, 2022
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
yubiuser
reviewed
Apr 4, 2022
yubiuser
approved these changes
Apr 4, 2022
PromoFaux
added a commit
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
Move some functionality out of webpage.sh and into utils.sh - keep the wrapper functions in webpage.sh for now as docker is currently using them - but these can go once we update docker container