Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable restoring Teleporter archives from the command line #5064

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

iain-henderson
Copy link

@iain-henderson iain-henderson commented Dec 14, 2022

…d line

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

In combination with updates to AdminLTE this PR enhances pihole so that it can restore a teleporter archive from the command line.

How does this PR accomplish the above?:

The addition of an argument to the teleporter arguments (i.e. pihole -a -t -r myname.tar.gz). This addition includes some additional argument parsing and help text.

Link documentation PRs if any are needed to support this PR:

pi-hole/docs#818


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign changed the title Update pihole to enable restoring Teleporter archives from the comman… Enable restoring Teleporter archives from the command line Dec 14, 2022
advanced/Scripts/webpage.sh Outdated Show resolved Hide resolved
@dschaper
Copy link
Member

@rdwebdesign In case you missed this.

rdwebdesign
rdwebdesign previously approved these changes Feb 21, 2023
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in basic-install.sh does not belong in your PR. Please rebase on latest developmentans squash all your commits down.

advanced/Scripts/webpage.sh Outdated Show resolved Hide resolved
advanced/Scripts/webpage.sh Outdated Show resolved Hide resolved
advanced/Scripts/webpage.sh Outdated Show resolved Hide resolved
advanced/Scripts/webpage.sh Outdated Show resolved Hide resolved
@yubiuser yubiuser added the Submitter Attention Required Need action from submitter to continue label Jun 5, 2023
@hubertbanas
Copy link

Thank you for this PR! I see potential for multi Pi-hole sync implementation for high availability.

When can we expect this PR to be merged?

@iain-henderson
Copy link
Author

My understanding is that these changes mirror an implementation in the next major release of Pi-Hole (but that could be a misunderstanding).

@iain-henderson iain-henderson reopened this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submitter Attention Required Need action from submitter to continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants