Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for valid OS via IPv4 and IPv6 #5399

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Check for valid OS via IPv4 and IPv6 #5399

wants to merge 1 commit into from

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

As requested: Backport of #5305 to v5.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser
Check for valid OS via IPv4 and IPv6
8d86a09 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser mentioned this pull request Sep 29, 2023
Merged
1 task
@yubiuser yubiuser requested review from a team and dschaper October 8, 2023 04:55
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Oct 11, 2023
@yubiuser
Copy link
Member Author

yubiuser commented Nov 4, 2023

Pinging @dschaper

@dschaper
Copy link
Member

dschaper commented Nov 4, 2023

Has anyone checked this on an IPv6 only setup?

@PromoFaux PromoFaux mentioned this pull request Mar 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER DL6ER approved these changes

@dschaper dschaper Awaiting requested review from dschaper

Assignees
No one assigned
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yubiuser @dschaper @DL6ER