adds selection for web root and admin interface subdirectory #5590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Pihole should be able to install the web interface at a different location than
/var/www/html/admin
, like/var/www/html/pihole
.How does this PR accomplish the above?:
I changed the hard coded paths for
/var/www/html
andadmin
in the pihole scripts with the two additional variablesWEB_ROOT
andADMIN_INTERFACE_SUBDIR
. They are set to the current values as default and a added dialog allows to change them. Also a single adaption to the pihole web repository was necessary, which later needs also a pull request.At the moment the adaptions to the tests are missing and I also changed the Github links to test this.
Can you please give me some feedback, if my current implementation is OK or what needs to be changed!? Also help/hints for the tests would be nice.
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase
)