Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated rules in sass 2.0 & updated dependencies #685

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Valexr
Copy link

@Valexr Valexr commented Oct 9, 2021

sass-migrator division **/*.scss

src/_layout.scss Show resolved Hide resolved
src/_viewer-360.scss Show resolved Hide resolved
@Valexr Valexr changed the title Fix deprecation rules in sass 2.0 & updeps Fixed deprecated rules in sass 2.0 & updated dependencys Oct 9, 2021
Copy link

@janbakker2525 janbakker2525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$version in src/_variables.scss misses a 0

src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
src/_variables.scss Show resolved Hide resolved
@Valexr
Copy link
Author

Valexr commented Oct 11, 2021

$version in src/_variables.scss misses a 0

fixed

@Valexr Valexr changed the title Fixed deprecated rules in sass 2.0 & updated dependencys Fixed deprecated rules in sass 2.0 & updated dependencies Oct 11, 2021
@NazimHAli
Copy link

Can this be merged?

@janbakker2525
Copy link

Yes (but I do not have write access)

@salamwaddah
Copy link

@jviotti do you have write access?

@jviotti
Copy link

jviotti commented Aug 18, 2022

I do not, sorry @salamwaddah

@blokhin
Copy link

blokhin commented Aug 18, 2022

Dear @codebling please, would you mind accepting 🙏

@codebling
Copy link
Contributor

@blokhin why are you tagging me?? I don't have any access to this repo

@codebling
Copy link
Contributor

I've approved, in case that helps.

@blokhin
Copy link

blokhin commented Aug 18, 2022

Ah, sorry, I've thought you might have the necessary rights. Unfortunately, the repo author Yan Zhu @picturepan2 does not respond for almost a year.

@codebling
Copy link
Contributor

That's unfortunate. Perhaps time for a fork?

@peterhil
Copy link

peterhil commented Feb 23, 2023

There is a SpectreCSS organisation, made by @picturepan2:
#684 (comment)

Ping: @codebling @jviotti @devmount

I really wish to continue using Spectre.css, and I am willing to contribute to it’s development.

@codebling
Copy link
Contributor

@peterhil are you tagging me because you want me to move the repo? I have no access to this repo.

Nobody except picturepan2 has access to this repo, as far as I can tell, and they have not been responsive to @ mentions in this repo for quite some time. The good news is, it's open source. I suggest someone fork (possibly into the org you mentioned) and add others as admins to the repo.

@davestewart
Copy link

davestewart commented Sep 19, 2023

To everyone who needs this, you can just do:

npm i Valexr/spectre

No other changes needed.

@Valexr - in lieu of someone creating a new repo and merging all the pending PRs, will you keep your repo up?

@Valexr
Copy link
Author

Valexr commented Sep 19, 2023

To everyone who needs this, you can just do:

npm i Valexr/spectre

No other changes needed.

@Valexr - in lieu of someone creating a new repo and merging all the pending PRs, will you keep your repo up?

I don't think so... @davestewart , there's no time to do it. I did it exclusively for a project that I don't support anymore.

@davestewart
Copy link

Ok, thanks for the info. I'll fork!

@ma4nn
Copy link

ma4nn commented Sep 19, 2023

I am using spectre.css in my projects a lot and really love its simplicity. So sad there is no solution to continue it within the current repo/setup/org.

In case there is any interest I would be willing to continue maintaining a fork for it.
I have merged the code changes from @Valexr into my fork vianetz/spectre-css and will create copies of other pull requests from the main repo that makes sense to me.

In addition I have setup Github Actions to automatically run the build process and added an action to automatically deploy the docs to https://vianetz.github.io/spectre-css/.

Let me know your input, I'm happy to merge more pull request proposals if they make sense.

@davestewart
Copy link

davestewart commented Sep 19, 2023

Yeah, I think it's about time.

I created an organisation called Picturepan Too (see what I did there?)

I figure this could be more neutral than a single developer having to take ownership.

I'm happy to add those who want to step up, or could just delete if it's deemed too complicated.

Would be good then to:

  • fork the original code
  • merge outstanding pull requests
  • publish a new package

Later improvements might include:

  • proper markdown docs
  • wrappers for Vue, React, etc
  • a @picturepan-too npm namespace

Thoughts? Suggestions?

EDIT: I created a discussion here.

@davestewart davestewart mentioned this pull request Sep 20, 2023
30 tasks
@niutech
Copy link

niutech commented Apr 3, 2024

This PR has been merged into my updated fork of Spectre 0.6.0.

@peterhil
Copy link

peterhil commented Apr 8, 2024

There is also spectre-org/spectre-css, but it’s updated some months ago, unlike niutech’s fork which is updated a few days ago.

@niutech
Copy link

niutech commented Apr 8, 2024

spectre-org/spectre-css 1.0.0. is based on 0.5.9 and update to 0.5.10 is yet to be done, whereas my fork is based on 0.5.10 with some updates, e.g. I am working on pure CSS tabs.

Ideally there should be a single community-driven up-to-date repo of Spectre, but it seems spectre-org/spectre-css development has stalled. Any updates @davestewart?

@davestewart
Copy link

davestewart commented Apr 9, 2024

Hey @niutech,

Thanks for the mention.

Yes, development has stalled; I got really busy last year and after releasing the new docs and site I didn't have much more time.

However, an interesting development from literally yesterday is that @picturepan2 followed me on Twitter so I sent him a message to bring him up to speed. Without pasting the bulk of the message, I ended with this:

Regarding going forwards, I guess the main questions are:

  • do you have or want to donate any time to spectre going forward?
  • are you interested in working with collaborators?
  • what are your thoughts on spectre.org?

I can see various routes:

  • effort moves more towards spectre.org; you come onboard in some capacity, (even just to validate the project, but hopefully more)
  • the new repos move towards you; I wouldn't be averse to donating the new docs repo if spectre under @picturepan2 had a future
  • you say you're not interested in the project anymore, and it's up to me to figure out where to go next
  • you're not happy with any of it, I guess then, you tell me where you're at!

I can actually find the time in the next few weeks / months to put some effort in.

I'd like to – at least help – get Spectre to a stage where it can live on for another few years, and it would be great if that was more of a community effort.

Watch this space; I'll certainly feed back on this thread, and hopefully there'll be some input from @picturepan2 as well.

And regards the .5.9 and .5.10 branches; unfortunately this PR messed with button margins, and I never had the time to correct this. At least, this is what the docs site shows. How did your merge go? Are the button margins OK?

If yours works correctly, I would be totally happy to re-merge a better version into the new core.

Cheers,
Dave

@niutech
Copy link

niutech commented Apr 9, 2024

@davestewart It would be great if you could devote your time to developing Spectre in the coming months. I'd try to submit some PR when I finish my work in progress.

As for buttons, they look OK in my fork: https://niutech.github.io/spectre/elements/buttons.html
Problem with your docs site is that it lacks space characters between <button>s due to HTML minification.

EDIT: I've implemented pure CSS tabs in my fork.

@davestewart
Copy link

davestewart commented Apr 10, 2024

Problem with your docs site is that it lacks space characters between <button>s due to HTML minification

OMG that's stung me before!!! That's for noticing that; at least I can solve that now 🙏

EDIT: I've implemented pure CSS tabs in my fork.

Do you want to create an issue to discuss on spectre-org?

@davestewart
Copy link

OK, the margin issues I mentioned above have now been fixed in the spectre-org docs so I now consider this PR properly merged in spectre-org/spectre-css 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet