Do not serve files when path ends with / #224

rmhaiderali · 2024-01-20T16:50:48Z

When index option is set to false and the environment is Windows, requests that end with a / might result in serving files. This happens because in Windows, when accessing a file or directory, if the path ends with /, the system first checks for a directory. If no directory is found, it then checks if a file with the same name exists, ignoring the / at the end of the path. This enables access to a file unexpectedly, as if the path did not conclude with /.

The proposed fix addresses this issue by introducing a check to ensure that the path does not ends with / before serving a file. For example, in the given case, file is being accessed when it should not be, and the proposed change aims to rectify this behavior.

index.js

var http = require("http");
var send = require("send");

var server = http.createServer(function onRequest(req, res) {
  send(req, "./index.html/", { index: false }).pipe(res);
});

server.listen(3000);

index.html

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Document</title>
  </head>
  <body>
    HTML File
  </body>
</html>

rmhaiderali added 2 commits January 20, 2024 20:55

Do not serve files when path ends with /

a420346

lint

9e865b4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not serve files when path ends with / #224

Do not serve files when path ends with / #224

rmhaiderali commented Jan 20, 2024 •

edited

Do not serve files when path ends with / #224

Are you sure you want to change the base?

Do not serve files when path ends with / #224

Conversation

rmhaiderali commented Jan 20, 2024 • edited

rmhaiderali commented Jan 20, 2024 •

edited