Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further type fixes #13705

Merged
merged 13 commits into from
Dec 1, 2022
Merged

Further type fixes #13705

merged 13 commits into from
Dec 1, 2022

Conversation

fashxp
Copy link
Member

@fashxp fashxp commented Nov 29, 2022 •
edited by mcop1

followup to #13653

TODO

@fashxp fashxp added this to the 11.0.0 milestone Nov 29, 2022
@github-actions
Copy link

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@fashxp fashxp added the Task label Nov 29, 2022
@dvesh3 dvesh3 mentioned this pull request Nov 30, 2022
Merged
@mcop1 mcop1 linked an issue Nov 30, 2022 that may be closed by this pull request
[Task]: Fix possible errors after applying php native types #13656
Closed
@brusch brusch mentioned this pull request Nov 30, 2022
Merged
brusch
brusch previously requested changes Nov 30, 2022
View reviewed changes
lib/Http/ResponseHelper.php Show resolved Hide resolved
@fashxp fashxp dismissed brusch’s stale review November 30, 2022 13:40

discussed and agreed

@mcop1 mcop1 merged commit 92da8b9 into 11.x Dec 1, 2022
@mcop1 mcop1 deleted the type-fixes branch December 1, 2022 12:20
@dvesh3 dvesh3 restored the type-fixes branch December 1, 2022 14:19
@mcop1 mcop1 deleted the type-fixes branch December 1, 2022 15:34
@robertSt7 robertSt7 mentioned this pull request Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvesh3 dvesh3 dvesh3 left review comments

@brusch brusch brusch left review comments

Assignees

@mcop1 mcop1

Labels
Task
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.

[Task]: Fix possible errors after applying php native types
5 participants
@fashxp @brusch @dvesh3 @mcop1 @robertSt7