Adding of an attribute "Public" or "Private" for each event on the calendar. #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
WhyNotHugo
requested changes
Dec 12, 2022
| @@ -493,7 +499,7 @@ def delete_instance(vevent: icalendar.Event, instance: dt.datetime) -> None: | |||
| vevent.pop('EXDATE') | |||
| vevent.add('EXDATE', exdates) | |||
| if 'RDATE' in vevent: | |||
| rdates = [one for one in _get_all_properties(vevent, 'RDATE') if one != instance] | |||
| rdates = [one for one in _get_allz_properties(vevent, 'RDATE') if one != instance] | |||
| ``None``, then ``event.calendar`` must be defined. | ||
|
|
||
| :param event: the event to be inserted. | ||
| def insert(self, event: Event, collection: Optional[str]=None) -> Event: |
There was a problem hiding this comment.
This function does not return anything.
I think you started of an old version of main which had typing wrong, but then mis-merged somehow? I do recall this being broken in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1019
Hello,
My name is Rafik, I am an engineering student. With my comrade Milo we worked on the adding of an attribute "Public" or "Private" for each event on the calendar. For now you can specify it with a character string when you press "n" to create an event and the latter is displayed in the ICS file. For the future we would like to do it with a clickable button with an "x" displayed in the middle of the button that is clicked and which automatically adds the attribute "Public" or "Private" to the ICS file. We also want to limit the access to the private events. Therefore only a list of people added by the creator of the event could access to it.
If you have any question about our work do not hesitate to write to us !
Rafik.