Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ldap storage #1061

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add ldap storage #1061

wants to merge 1 commit into from

Conversation

nblock
Copy link
Contributor

@nblock nblock commented Apr 11, 2023

The ldap backend is currently limited to a few attributes (mostly phone related) but I'm willing to expand this to other vcard fields. It is currently being tested with an OpenLDAP server and supports the inetOrgPerson schema. In my test setup I'm syncing from Nextcloud to OpenLDAP and from OpenLDAP to filesystem. This PR is not complete yet, but I'm looking for feedback.

Tasks:

  • List entries in LDAP
  • Get an entry from LDAP
  • Create new entry in LDAP
  • Update an existing entry in LDAP
  • Delete an entry from LDAP
  • Support metadata?
  • Support collections?
  • Fix CI builds
  • Fix tests
  • Documentation
  • Cleanup, squash and proper commit message

This is more or less a continuation of #500 by @paulfariello (thanks for your effort!).

See also: #500
Fixes: #283

@nblock nblock marked this pull request as draft April 11, 2023 13:51
@WhyNotHugo
Copy link
Member

I'm not very familiar with LDAP, but don't see anything obviously wrong here.

I'm curious about the LDAP<>vcard conversion that you're doing. Some fields in vcard don't seem to be supported in LDAP. This means that when you sync vcard->ldap the fields are dropped, but if things later change on the LDAP side and the contact is synced ldap->vcard those dropped fields will be lost forever, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP support
2 participants