Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apple Silicon / Darwin arm64 compatibility #940

Merged
merged 2 commits into from
Jun 24, 2021
Merged

fix: Apple Silicon / Darwin arm64 compatibility #940

merged 2 commits into from
Jun 24, 2021

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Jun 23, 2021 •
edited

Fix backend compilation problem in darwin-arm64. And after testing, frontend now works fine with the latest node version.
close #826

@shhdgit shhdgit requested a review from breezewish June 24, 2021 01:18
breezewish
breezewish approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7b8bf05

@ti-chi-bot ti-chi-bot merged commit fd9f9e6 into pingcap:master Jun 24, 2021
shhdgit added a commit to shhdgit/tidb-dashboard that referenced this pull request Jul 6, 2021
@shhdgit
fix: Apple Silicon / Darwin arm64 compatibility (pingcap#940)
21a1529
breezewish pushed a commit that referenced this pull request Jul 6, 2021
@shhdgit
Release TiDB Dashboard v2021.07.06.1 (#949)
dd6104f 
* tweak(ui): support `sameWeek` format (#937)
* fix(stmt & slowquery): ignored virtual fields (#939)
* fix: Apple Silicon / Darwin arm64 compatibility (#940)
* fix(tidb-client): wrong status api property (#944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend cannot compile in ARM
3 participants
@shhdgit @ti-chi-bot @breezewish