Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: global index support admin check table | index #53156

Merged
merged 14 commits into from May 13, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented May 10, 2024

What problem does this PR solve?

Issue Number: close #53019, ref #52897

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Defined2014 Defined2014 changed the title *: global index support admin check table | index *: global index support admin check table | index May 10, 2024
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2024
Copy link

tiprow bot commented May 10, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.4663%. Comparing base (600b2ed) to head (1353407).
Report is 63 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53156        +/-   ##
================================================
+ Coverage   72.0365%   74.4663%   +2.4297%     
================================================
  Files          1499       1512        +13     
  Lines        431224     447965     +16741     
================================================
+ Hits         310639     333583     +22944     
+ Misses       101303      94079      -7224     
- Partials      19282      20303      +1021     
Flag Coverage Δ
integration 49.3668% <73.9130%> (?)
unit 71.5245% <95.6521%> (+0.2774%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0820% <ø> (+7.7174%) ⬆️

@Defined2014
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented May 10, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2024
@@ -1481,7 +1481,7 @@ func (b *PlanBuilder) buildAdmin(ctx context.Context, as *ast.AdminStmt) (base.P

func (b *PlanBuilder) buildPhysicalIndexLookUpReader(_ context.Context, dbName model.CIStr, tbl table.Table, idx *model.IndexInfo) (base.Plan, error) {
tblInfo := tbl.Meta()
physicalID, isPartition := getPhysicalID(tbl)
physicalID, isPartition := getPhysicalID(tbl, idx.Global)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

planner part LGTM

Copy link

ti-chi-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-11 09:34:04.377695474 +0000 UTC m=+1300198.134831048: ☑️ agreed by zimulala.
  • 2024-05-13 06:02:51.633471375 +0000 UTC m=+1460325.390606948: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit b1818cd into pingcap:master May 13, 2024
23 checks passed
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global index add support for check index/check table
3 participants