Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl,mdl: fix the issue that the table_ids overlap regex is not correct (#52879) #53190

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52879

What problem does this PR solve?

Issue Number: close #52758

Problem Summary:

The regexp in mdl_view is not correct:

SELECT ',10,` regexp ',1|2,'

This SQL will return 1, because it actually matches ',1' or '2,'.

What changed and how does it work?

This PR modified the REGEXP from ,1|2, to ,(1|2),.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@29c0e5a). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53190   +/-   ##
================================================
  Coverage               ?   71.2848%           
================================================
  Files                  ?       1465           
  Lines                  ?     422303           
  Branches               ?          0           
================================================
  Hits                   ?     301038           
  Misses                 ?     100827           
  Partials               ?      20438           
Flag Coverage Δ
unit 71.2848% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9907% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 13, 2024
@YangKeao YangKeao requested a review from wjhuang2016 May 13, 2024 06:25
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-13 08:28:54.377027429 +0000 UTC m=+1469088.134163001: ☑️ agreed by wjhuang2016.
  • 2024-05-13 08:34:07.512724441 +0000 UTC m=+1469401.269860013: ☑️ agreed by YangKeao.

@YangKeao YangKeao requested a review from YuJuncen May 13, 2024 08:56
@easonn7
Copy link

easonn7 commented May 14, 2024

/approve

Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, wjhuang2016, YangKeao, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit 41b7a58 into pingcap:release-8.1 May 14, 2024
37 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants