Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/ranger: Handle boundary value correctly in ranger to avoid incorrect tableDual plan (#52225) #53319

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52225

What problem does this PR solve?

Issue Number: close #50051

Problem Summary:

The function excludeToIncludeForIntPoint should deal with the boundary value correctly.

What changed and how does it work?

I guess it is not a bad idea to change the type of the point in this case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@335e834). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #53319   +/-   ##
================================================
  Coverage               ?   74.5230%           
================================================
  Files                  ?       1097           
  Lines                  ?     360270           
  Branches               ?          0           
================================================
  Hits                   ?     268484           
  Misses                 ?      75040           
  Partials               ?      16746           

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 5, 2024
Copy link

ti-chi-bot bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-05 01:30:31.075198696 +0000 UTC m=+3431184.832334269: ☑️ agreed by hawkingrei.
  • 2024-06-05 03:18:37.768842133 +0000 UTC m=+3437671.525977711: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 8e70343 into pingcap:release-6.5 Jun 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants