New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote read DagRequest has incorrect flags field #8607
Labels
Comments
12 tasks
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this issue
Dec 27, 2023
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this issue
Dec 27, 2023
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this issue
Dec 27, 2023
12 tasks
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this issue
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
When we build RemoteRequest in following function, we don't set DagRequest's flags field, leaving it default value. The falgs field will decide if TiFlash should ignore certain warnings:
https://github.com/pingcap/tiflash/blob/cea7c80823e05173db7983bd6eecf0b81dc96761/dbms/src/Flash/Coprocessor/RemoteRequest.cpp#L24C1-L32C27
It may cause problems if the DagRequest contains filter operations and these filter operations produce truncate warning or other warnings.
The text was updated successfully, but these errors were encountered: