Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set remote requst's DagRequest flags field #8606

Merged
merged 13 commits into from
Dec 27, 2023
Merged

Set remote requst's DagRequest flags field #8606

merged 13 commits into from
Dec 27, 2023

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Dec 27, 2023 •
edited

What problem does this PR solve?

Issue Number: close #8607

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

yibin87 and others added 10 commits December 25, 2023 18:04
@yibin87
Fix 8562 issue to handle ColumnNothing column
a79a02e 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Merge branch 'master' into fix_npe_join
802cb9a
@yibin87
Little update
2a29a90 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Address comments
cc01025 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Fix format issue
c806c56 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Update test
425fed5 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot
Merge branch 'master' into fix_npe_join
d3fc2ef
@yibin87
update test
983bf21 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
fix integration test
63cc658 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Set remote request flags
092fb91 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 27, 2023

/run-all-tests

@yibin87
Add full stack test
8099843 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 27, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 27, 2023

/run-all-tests

@yibin87
Set sql mode also
1193123 
Signed-off-by: yibin <huyibin@pingcap.com>
windtalker
windtalker approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yibin87
Copy link
Contributor Author

yibin87 commented Dec 27, 2023

/run-all-tests

xzhangxian1008
xzhangxian1008 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 27, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-27 08:55:00.440559302 +0000 UTC m=+1642391.477786227: ☑️ agreed by windtalker.
  • 2023-12-27 09:06:45.150745983 +0000 UTC m=+1643096.187972909: ☑️ agreed by xzhangxian1008.

@ti-chi-bot ti-chi-bot bot merged commit 813f475 into pingcap:master Dec 27, 2023
6 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8609.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 27, 2023
@yibin87 @ti-chi-bot
Set remote requst's DagRequest flags field (pingcap#8606)
e7746f8 
close pingcap#8607
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8610.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 27, 2023
@yibin87 @ti-chi-bot
Set remote requst's DagRequest flags field (pingcap#8606)
dd74c1a 
close pingcap#8607
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8611.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 27, 2023
@yibin87 @ti-chi-bot
Set remote requst's DagRequest flags field (pingcap#8606)
c867c37 
close pingcap#8607
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8612.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
12 tasks
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Dec 27, 2023
@yibin87 @JaySon-Huang
Set remote requst's DagRequest flags field (pingcap#8606)
b270e26 
close pingcap#8607
ti-chi-bot bot pushed a commit that referenced this pull request Dec 28, 2023
@ti-chi-bot
Set remote requst's DagRequest flags field (#8606) (#8611)
b66f685 
close #8607
ti-chi-bot bot pushed a commit that referenced this pull request Dec 28, 2023
@ti-chi-bot
Set remote requst's DagRequest flags field (#8606) (#8610)
9f143b9 
close #8607
ti-chi-bot bot pushed a commit that referenced this pull request Dec 28, 2023
@ti-chi-bot
Set remote requst's DagRequest flags field (#8606) (#8609)
0b20c02 
close #8607
ti-chi-bot bot pushed a commit that referenced this pull request Dec 28, 2023
@ti-chi-bot
Set remote requst's DagRequest flags field (#8606) (#8612)
2ffe43c 
close #8607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.1 Type: Need cherry pick to release-6.1 needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.1 needs-cherry-pick-release-7.5 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remote read DagRequest has incorrect flags field
4 participants
@yibin87 @ti-chi-bot @windtalker @xzhangxian1008