-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semi and cross semi join kind #8263
Conversation
/run-all-tests |
9ecfadb
to
15d469a
Compare
/run-all-tests |
1 similar comment
/run-all-tests |
be2df2b
to
4560d99
Compare
/run-all-tests |
/run-all-tests |
Signed-off-by: gengliqi <gengliqiii@gmail.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #8262
Problem Summary:
What is changed and how it works?
In the current implementation, the semi join without other conditions is marked by
inner join
andstrictness: any
. The one with other conditions is marked byinner join
andstrictness: all && original_strictness: any
.It is really confusing so I add the semi and cross semi join kind to separate semi join and inner join.
Check List
Tests
Side effects
Documentation
Release note