-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix sync empty schema diff #8623
ddl: Fix sync empty schema diff #8623
Conversation
/run-all-tests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-unit-test |
In response to a cherrypick label: new pull request created to branch |
/cherry-pick release-7.5 |
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflash#release-7.5 from head ti-chi-bot:cherry-pick-8623-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.5 and ti-chi-bot:cherry-pick-8623-to-release-7.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} |
@ti-chi-bot: new pull request could not be created: failed to create pull request against pingcap/tiflash#release-7.5 from head ti-chi-bot:cherry-pick-8623-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.5 and ti-chi-bot:cherry-pick-8623-to-release-7.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #8578, close #8289
Problem Summary: When there is conflict in concurrency DDL, it will skip some schema version, which generate an empty SchemaDiff.
What is changed and how it works?
Skip when meets an empty SchemaDiff in the non-latest schema version
As that in the relese-7.1 branch #8578 (comment)
tiflash/dbms/src/TiDB/Schema/TiDBSchemaSyncer.h
Lines 233 to 262 in 9f7e054
Refine the readme of running integration tests in local
Check List
Tests
Side effects
Documentation
Release note