Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix In ScalarFunc in RoughSetFilter #8634

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jan 2, 2024

What problem does this PR solve?

Issue Number: close #8631

Problem Summary:

What is changed and how it works?

reject all children which are not ColumnRef or Literal.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the wrong result when executing queries with a filter like `ColumnRef in (Literal, Func...)`

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none needs-cherry-pick-release-7.5 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2024
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor

Please update the "Release note" to descript what problem it fixes

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Jan 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-02 04:39:59.068288753 +0000 UTC m=+2145490.105515662: ☑️ agreed by JaySon-Huang.
  • 2024-01-02 05:23:39.899513985 +0000 UTC m=+2148110.936740903: ☑️ agreed by JinheLin.

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

/run-unit-test

@JaySon-Huang
Copy link
Contributor

fix expression like ColumnRef in (Literal, Func...) in rough set filter.

Your release note describes "what codes you changed" but not "what problem you fixed". Suggest using "Fix the wrong result when executing queries with filter IN CAST(.. AS ..)"

@Lloyd-Pottiger
Copy link
Contributor Author

fix expression like ColumnRef in (Literal, Func...) in rough set filter.

Your release note describes "what codes you changed" but not "what problem you fixed". Suggest using "Fix the wrong result when executing queries with filter IN CAST(.. AS ..)"

change to:

Fix the wrong result when executing queries with a filter like ColumnRef in (Literal, Func...)

@Lloyd-Pottiger
Copy link
Contributor Author

/run-integration-test

@Lloyd-Pottiger
Copy link
Contributor Author

/run-unit-test

@Lloyd-Pottiger
Copy link
Contributor Author

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 6cae6e9 into pingcap:master Jan 2, 2024
6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8639.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 2, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jan 3, 2024
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-rs-in branch January 12, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In rough set filter works occasionally incorrectly
4 participants