New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: remove metrics proxy #6948
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6948 +/- ##
================================================
+ Coverage 59.8253% 59.8985% +0.0732%
================================================
Files 791 788 -3
Lines 90221 90301 +80
================================================
+ Hits 53975 54089 +114
+ Misses 31498 31470 -28
+ Partials 4748 4742 -6 |
/run-engine-integration-test |
The integration test is fixed in this pr, please rebase this branch and trigger engine tests again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind introduce a bit below this comment about why we used this before and why we abandon it now?
see pingcap/dm#575 for more detail. We want to remove metrics when task/source stopped. However, our metrics don't quite fit the specification. e.g. txnHistogram is created with target_schema/target_table label, but we need to remove them when their task/source is deleted, so we need delete the metrics when label is partial match. pingcap/dm#575 wraps metrics and label with a Map, which has perfomance issue. Promethus support |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d689bae
|
What problem does this PR solve?
Issue Number: ref #4287
What is changed and how it works?
DeletePartialMatch
if we want to delete by partial labels.Check List
Tests
Manaully test