Skip to content

Commit

Permalink
[FIX]: web-ui: Check in @babel/runtime dependency version
Browse files Browse the repository at this point in the history
babel/babel#8462

Webpack fails to load @babel/runtime helper functions (required by antd, rc-*) due to the import specifier not being fully resolved (missing .js, .mjs extension)

This is fixed in @babel/runtime 7.12.0 but antd does not require the latest @babel/runtime by default

So a peer dependency of @babel/runtime@>=7.12.1 (currently latest) is added
  • Loading branch information
lokshunhung committed Oct 27, 2020
1 parent 5c797f0 commit b6abf47
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions packages/web-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"moment": "2.29.1"
},
"peerDependencies": {
"@babel/runtime": ">=7.12.1",
"react": ">=16.14.0",
"react-dom": ">=16.14.0",
"react-router-dom": ">=5.2.0"
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -978,9 +978,9 @@
regenerator-runtime "^0.13.4"

"@babel/runtime@^7.0.0", "@babel/runtime@^7.1.2", "@babel/runtime@^7.10.1", "@babel/runtime@^7.10.2", "@babel/runtime@^7.10.3", "@babel/runtime@^7.10.4", "@babel/runtime@^7.11.1", "@babel/runtime@^7.11.2", "@babel/runtime@^7.5.5", "@babel/runtime@^7.8.4", "@babel/runtime@^7.9.2", "@babel/runtime@^7.9.6":
version "7.11.2"
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.11.2.tgz#f549c13c754cc40b87644b9fa9f09a6a95fe0736"
integrity sha512-TeWkU52so0mPtDcaCTxNBI/IHiz0pZgr8VEFqXFtZWpYD08ZB6FaSwVAS8MKRQAP3bYKiVjwysOJgMFY28o6Tw==
version "7.12.1"
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.12.1.tgz#b4116a6b6711d010b2dad3b7b6e43bf1b9954740"
integrity sha512-J5AIf3vPj3UwXaAzb5j1xM4WAQDX3EMgemF8rjCP3SoW09LfRKAXQKt6CoVYl230P6iWdRcBbnLDDdnqWxZSCA==
dependencies:
regenerator-runtime "^0.13.4"

Expand Down

0 comments on commit b6abf47

Please sign in to comment.