Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced t.indexOf() by t.match() #357

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Replaced t.indexOf() by t.match() #357

merged 1 commit into from
Jun 22, 2022

Conversation

marcelfranca
Copy link
Contributor

Fix issue #356

@marcelfranca marcelfranca marked this pull request as ready for review June 22, 2022 14:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2542921907

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2542671985: 0.0%
Covered Lines: 383
Relevant Lines: 383
💛 - Coveralls

mcollina
mcollina approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3bc3a05 into pinojs:master Jun 22, 2022
mcollina pushed a commit that referenced this pull request Aug 10, 2022
@marcelfranca @mcollina
Replaced t.indexOf() by t.match() (#357)
c270ec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcelfranca @coveralls @mcollina