feat: Provide colorette object to messageFormat #494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables users to use available colors based on `colorize` context of the pino-pretty instance
|
Question though...would it be acceptable to extend this functionality to EDIT: A combined branch example of providing colors to all prettifiers -- see usage under customPrettifiers section in readme https://github.com/FoxxMD/pino-pretty/tree/additionalFunctionality?tab=readme-ov-file#options |
FoxxMD
added a commit
to FoxxMD/pino-pretty
that referenced
this pull request
Feb 26, 2024
Enables users to use available colors based on `colorize` context of the pino-pretty instance Variant of pinojs#494 that provides colors as extras object for compatibility with future customPrettifier extras argument
mcollina
pushed a commit
that referenced
this pull request
Mar 20, 2024
…rmat (#495) * feat: Add label and colorized output for level customPrettifier func Same implementation as #493 but using object for extras argument for compatibility with future signature expansion * feat: Provide colorette object to message format function Enables users to use available colors based on `colorize` context of the pino-pretty instance Variant of #494 that provides colors as extras object for compatibility with future customPrettifier extras argument * feat: Provide colorette object to prettifyObject All keys for customPrettifier, other than logs, now provide colors as property on an additional `extras` object for the prettifyObject function signature * feat: Add colors to level prettifier function signature * Modify level prettifier function signature to match other prettifiers * Since only the first argument was documented anyway this shouldn't be a breaking change. * docs: Update docs to showcase colors and standard customPrettifiers function signature * fix: Missing colors on colorizer when custom level colors are provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables users to use available colors based on
colorizecontext of the pino-pretty instance.Currently if a user wants to color their messages they need to create their own instances of Colorette and implement logic, outside of pino-pretty, to make sure the
useColorsoption passed matches what was given to pino-pretty ascolorize. However pino-pretty already has this object available...this PR extendsmessageFormatto add the existing Colorette instance as a fourth parameter so that the user doesn't need to do that extra work.