Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add injection of lacking arguments of customPrettifiers #501

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pasha-vuiko
Copy link

resolves #500

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@pasha-vuiko
Copy link
Author

Thanks for opening a PR! Can you please add a unit test?

done

@pasha-vuiko pasha-vuiko changed the title fix: add injection lacking arguments of customPrettifiers fix: add injection of lacking arguments of customPrettifiers Mar 26, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/utils/prettify-metadata.test.js Outdated Show resolved Hide resolved
@pasha-vuiko
Copy link
Author

@jsumners could you re-review please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PinoPretty.customPrettifiers() lacks arguments declared in type PinoPretty.Prettifier
3 participants