Fix escape backslashes in file paths on Windows #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. You can see that CI is red, can you please fix it? Also, as part of this it would be good if we changed CI to also run on Windows, so that we can actually check that this change works correctly |
|
what's missing here? |
|
Sorry, I encountered many errors in the Windows test, but I don't have more time to solve them. Anyone is welcome to take over this pull request, or I can convert it into an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation for handling file paths on Windows is causing issues when using the \ separator. This is because the \ sequence is being treated as an escape sequence, which leads to the incorrect parsing of file paths.