Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up pino-std-serializers dependency #946

Merged
merged 2 commits into from Jan 8, 2021
Merged

Conversation

al-bglhk
Copy link
Contributor

@al-bglhk al-bglhk commented Jan 8, 2021

It's been several versions since pino-std-serializers was aligned with pino

@al-bglhk
Copy link
Contributor Author

al-bglhk commented Jan 8, 2021

I have updated the test case so it will now refer to request.socket instead of request.connection.
And skipped tests that expect request.connection (now request.socket) to be undefined, because request.socket is always available.

  • request.connection has been deprecated since Node13
  • request.socket interface is compatible with request.connection since v0.3.0, or at least v10

@mcollina mcollina requested a review from jsumners January 8, 2021 09:05
@@ -1,6 +1,6 @@
{
"name": "pino",
"version": "6.9.0",
"version": "6.9.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this

@mcollina
Copy link
Member

mcollina commented Jan 8, 2021

@jsumners did you recall why we did not bump this?

@jsumners
Copy link
Member

jsumners commented Jan 8, 2021

@jsumners did you recall why we did not bump this?

Likely because it is a major version increase or we just didn't think about it. But, it being a major version increase, I wonder if this PR should target v7?

@mcollina
Copy link
Member

mcollina commented Jan 8, 2021

It's just a drop of old node.js versions: pinojs/pino-std-serializers#40.

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants