Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up pino-std-serializers dependency #946

Merged
merged 2 commits into from Jan 8, 2021
Merged

Bump up pino-std-serializers dependency #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26ecf0b
Bump up pino-std-serializers dependency
al-bglhk Jan 8, 2021
a8ec09e
fixed test case to now use request.socket instead of request.connecti…
Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "pino",
"version": "6.9.0",
"version": "6.9.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this

"description": "super fast, all natural json logger",
"main": "pino.js",
"browser": "./browser.js",
Expand Down Expand Up @@ -88,7 +88,7 @@
"fast-redact": "^3.0.0",
"fast-safe-stringify": "^2.0.7",
"flatstr": "^1.0.12",
"pino-std-serializers": "^2.4.2",
"pino-std-serializers": "^3.1.0",
"quick-format-unescaped": "^4.0.1",
"sonic-boom": "^1.0.2"
}
Expand Down
21 changes: 11 additions & 10 deletions test/http.test.js
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
const http = require('http')
const os = require('os')
const semver = require('semver')
const { test } = require('tap')
const { test, skip } = require('tap')
const { sink, once } = require('./helper')
const pino = require('../')

Expand All @@ -24,8 +24,8 @@ test('http request support', async ({ ok, same, error, teardown }) => {
method: originalReq.method,
url: originalReq.url,
headers: originalReq.headers,
remoteAddress: originalReq.connection.remoteAddress,
remotePort: originalReq.connection.remotePort
remoteAddress: originalReq.socket.remoteAddress,
remotePort: originalReq.socket.remotePort
}
})
}))
Expand Down Expand Up @@ -62,8 +62,8 @@ test('http request support via serializer', async ({ ok, same, error, teardown }
method: originalReq.method,
url: originalReq.url,
headers: originalReq.headers,
remoteAddress: originalReq.connection.remoteAddress,
remotePort: originalReq.connection.remotePort
remoteAddress: originalReq.socket.remoteAddress,
remotePort: originalReq.socket.remotePort
}
})
}))
Expand All @@ -83,7 +83,8 @@ test('http request support via serializer', async ({ ok, same, error, teardown }
server.close()
})

test('http request support via serializer without request connection', async ({ ok, same, error, teardown }) => {
// skipped because request connection is deprecated since v13, and request socket is always available
skip('http request support via serializer without request connection', async ({ ok, same, error, teardown }) => {
var originalReq
const instance = pino({
serializers: {
Expand All @@ -104,8 +105,8 @@ test('http request support via serializer without request connection', async ({
}
}
if (semver.gte(process.version, '13.0.0')) {
expected.req.remoteAddress = originalReq.connection.remoteAddress
expected.req.remotePort = originalReq.connection.remotePort
expected.req.remoteAddress = originalReq.socket.remoteAddress
expected.req.remotePort = originalReq.socket.remotePort
}
same(chunk, expected)
}))
Expand Down Expand Up @@ -217,8 +218,8 @@ test('http request support via serializer in a child', async ({ ok, same, error,
method: originalReq.method,
url: originalReq.url,
headers: originalReq.headers,
remoteAddress: originalReq.connection.remoteAddress,
remotePort: originalReq.connection.remotePort
remoteAddress: originalReq.socket.remoteAddress,
remotePort: originalReq.socket.remotePort
}
})
}))
Expand Down