use safe-stable-stringify library #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
The latest PR to be tested out is BridgeAR/safe-stable-stringify#22 |
|
Also note that this change needs to be validated using the repro provided in #990 |
|
I don't understand thee last two comments |
|
@mcollina there are now 3 PRs doing the same thing in the safe-stable-stringify repo, it's to give context to whom is working on this of where to look and what this was supposed to fix in the first place, as this information is now scattered around various PRs and issues. |
|
#1169 supersedes this PR. We can close this one |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR lands, it will be possible to configure the external library pino uses to serialize object, to limit the depth/breadth
Refs: #1120, #1121