Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transports doc pipeline example #1530

Merged
merged 1 commit into from Aug 25, 2022
Merged

Conversation

AceFire6
Copy link
Contributor

@AceFire6 AceFire6 commented Aug 25, 2022

This thread gave me the clue I needed to get this example working. It seems like pino-pretty requires NDJSON input. In the example the newline is omitted which means the logs will never be emitted.

This PR updates the example to include a newline after the JSON.stringify to fix that.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good spot!

@mcollina mcollina merged commit c31bb1b into pinojs:master Aug 25, 2022
@AceFire6 AceFire6 deleted the patch-1 branch August 25, 2022 13:18
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants