Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added onChild callback with tests and documentation #1541

Merged
merged 6 commits into from Sep 5, 2022
Merged

Added onChild callback with tests and documentation #1541

merged 6 commits into from Sep 5, 2022

Commits on Aug 31, 2022

  1. Added onChild callback with tests and documentation

    @Diabl0269
    Diabl0269 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    386f46f View commit details
    Browse the repository at this point in the history

  2. Update onChild type to also be in options and added types tests

    @Diabl0269
    Diabl0269 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    3a85fcd View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: James Sumners <james@sumners.email>
    @Diabl0269 @jsumners
    Diabl0269 and jsumners committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    5958758 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge branch 'master' into master

    @Diabl0269
    Diabl0269 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    ffbb2a3 View commit details
    Browse the repository at this point in the history

  2. updated documentation

    @Diabl0269
    Diabl0269 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    df31031 View commit details
    Browse the repository at this point in the history

  3. Updated documentation. 

    Expanded `onChild` documentation to mention the function doesn't handle errors
    @Diabl0269
    Diabl0269 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    17900b7 View commit details
    Browse the repository at this point in the history