Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct type of args passed to hooks.logMethod #1558

Merged
merged 1 commit into from Sep 17, 2022

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Sep 15, 2022

Using any[] produces a type error when using method.apply(this, inputArgs).

image

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SimenB
Copy link
Contributor Author

SimenB commented Sep 16, 2022

Rebased both open PRs to retrigger CI (and to resolve a conflict in this one)

@mcollina mcollina merged commit 4f9e5a6 into pinojs:master Sep 17, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
@SimenB SimenB deleted the patch-1 branch September 18, 2023 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants