Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add this to hooks.logMethod #1559

Merged
merged 1 commit into from Sep 16, 2022
Merged

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Sep 15, 2022

This way, one can access e.g. this.levels

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SimenB
Copy link
Contributor Author

SimenB commented Sep 15, 2022

I don't think the failing test is on me, seeing as I've only changed type definitions

@mcollina mcollina merged commit a769539 into pinojs:master Sep 16, 2022
@SimenB SimenB deleted the this-in-hooks branch September 16, 2022 09:39
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants