Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type formatters.log with a Record type #1561

Merged
merged 1 commit into from Sep 16, 2022
Merged

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Sep 16, 2022

We have a massageLogData which takes an object with some custom types - object is not assignable to it. object just means non-primitive - it doesn't mean Object (which is discouraged, see https://github.com/typescript-eslint/typescript-eslint/blob/739479692bedb4aeca8c3d0c657f88d9c60f1fe0/packages/eslint-plugin/src/rules/ban-types.ts#L86-L88)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7962c76 into pinojs:master Sep 16, 2022
@SimenB SimenB deleted the patch-2 branch September 16, 2022 14:11
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants